# Description
rive-runtime is building, but now its failing on the silvers. I **think** it could be because we need to git pull lfs the srivs so trying that.
Diffs=
9d516a9ece rive-runtime pull silver rivs (#9384)
Co-authored-by: Philip Chung <philterdesign@gmail.com>
# Description
Previous PR to fix rive-runtime test had the path relative to mono, not relative to rive-runtime.
Diffs=
bd512ec1d9 Fix glfw working path (#9382)
Co-authored-by: Philip Chung <philterdesign@gmail.com>
# Description
Mac unit tests for the downstream rive-runtime have been failing for some time. Looks like glfw wasn't being built in the downstream workflow.
# Details
This PR adds the Build glfw step that we do in our mono repo into the rive-runtime test workflow. Ran it locally, was able to repro the test error and this fixes the issue locally.
```
../../../../renderer/path_fiddle/fiddle_context_gl.cpp:23:10: fatal error: 'GLFW/glfw3.h' file not found
hb-ot-map.cc
#include "GLFW/glfw3.h"
^~~~~~~~~~~~~~
```
Diffs=
92a4d0a287 Fix Rive-runtime tests (#9381)
Co-authored-by: Philip Chung <philterdesign@gmail.com>
- Most of tools/* have been moved to the new packages/runtime/tests. (Excludes fuzz and a few things with proprietary information)
- The tools/test are now in packages/runtime/unit_tests/renderer.
- The runtime/tests are now also moved, to the following packages/runtime/unit_tests/runtime (moved the "dev/tests" to packages/runtime/unit_tests)
- Thus unit_tests comprises of runtime and renderer tests (in the future we can add more categories as folder, this avoids too many tests in one folder)
- The rendering tests and runtime tests are built together in one executable called unit_tests*. This is what is described in the rive-runtime README - it is the way our developers can test the rendering (GPU) and runtime (CPU) unit tests in one go.
- pr_runtime_tests now builds and runs all the unit_tests, previously it was only executing the runtime tests, but now it includes the renderer tests for the (same platforms still tested: windows, windows msvc, mac, linux)
- The pr_tools_tests still tests the same workloads on the same devices, limited still to the rendering tests
ISSUES:
- We cannot build all the "tools" tests (e.g. imagediff, rendering tests) with the runtime tests. The runtime tests enables TESTING. I'm also not sure if running the runtime tests on all the devices is actually is worth it - if the tests are platform+device agnostic then probably not worth it.
- Windows pr_runtime_tests switched to ws-actions/configure-aws-credentials@v1 from microsoft/setup-msbuild@v1.1, as would not build otherwise, seems related to old version of premake
TODO:
- Verify of the performance is reasonable for runner / checkins
Diffs=
f25ee97a0 Opensource (tools) tests as part of runtime (#8035)
Co-authored-by: rivessamr <suki@rive.app>
Updating the line breaker to support:
- forced line breaks (return characters)
- store break points in context of runs (no searching when breaking)
- perform alignment (center/left/right)
In order to implement tests for this in Rive, I moved the Harfbuzz shaper into Rive (conditionally compiled out) but now we can test line-breaking logic in Rive core.
Since I had to update some of the build scripts, I ran the same new premake formatter we've been using.
<img width="910" alt="CleanShot 2022-09-19 at 21 03 53@2x" src="https://user-images.githubusercontent.com/454182/191164998-6b7b131b-b624-41c7-81d2-c2e01a050680.png">
Diffs=
a1d921c85 Line breaker (#4249)
Adds ability to run tests when building rive_tess:
```
cd packages/runtime/tess/build/macosx
./build_tess.sh test
```
Also runs them in GitHub Actions.
Diffs=
265e9c7aa Run tests for rive_tess
Adding newline to fix diff.
Update tests.yml
Update tests.yml
See rive.make
Attempt using a pre-generate makefile.
Update tests.yml
Remove windows make
One more windows test.
Make with verbose.
Trying verbose ar.exe
Retry
Make without parallel
More debug
Trying to fix this wsl issue
Seeing which version of make we have on github actions
Use an instance of the artboard for SMI test
Attempt wsl
Attempt wsl
install unzip
Again..
try to get unzip
add to path instead of github_path with wsl
just move premake to bin
use correct filename for premake
use crlf
Back to crlf
space
Attempt using just powershell
premake with powershell
call msbuild
add msbuild to path
Proper msbuild config
more args
Build rive tests
use right solution name
Use any cpu for tests
remove the config and platform
Update tests for windows
LS right dir
look for exe
Tests!
Add “b” so windows reads in binary mode
More “rb” fixes
Final “rb” fix!
