mirror of
https://github.com/rive-app/rive-cpp.git
synced 2026-01-18 21:21:17 +01:00
Fix Rive-runtime tests
# Description
Mac unit tests for the downstream rive-runtime have been failing for some time. Looks like glfw wasn't being built in the downstream workflow.
# Details
This PR adds the Build glfw step that we do in our mono repo into the rive-runtime test workflow. Ran it locally, was able to repro the test error and this fixes the issue locally.
```
../../../../renderer/path_fiddle/fiddle_context_gl.cpp:23:10: fatal error: 'GLFW/glfw3.h' file not found
hb-ot-map.cc
#include "GLFW/glfw3.h"
^~~~~~~~~~~~~~
```
Diffs=
92a4d0a287 Fix Rive-runtime tests (#9381)
Co-authored-by: Philip Chung <philterdesign@gmail.com>
This commit is contained in:
4
.github/workflows/tests.yml
vendored
4
.github/workflows/tests.yml
vendored
@@ -62,6 +62,10 @@ jobs:
|
||||
./build.sh
|
||||
./build.sh release
|
||||
|
||||
- name: Build glfw
|
||||
working-directory: packages/runtime/skia/dependencies/
|
||||
run: ./make_glfw.sh
|
||||
|
||||
- name: Tests
|
||||
if: matrix.platform == 'macOS'
|
||||
run: |
|
||||
|
||||
@@ -1 +1 @@
|
||||
c4dcac323291c2ed9f26752f0d3fd2c0ef0e9a27
|
||||
92a4d0a287ad36dbb5bf4b0dc5ffbe2b43ff12ff
|
||||
|
||||
Reference in New Issue
Block a user