Mirrors/rive-cpp
0
0
Fork 0
mirror of https://github.com/rive-app/rive-cpp.git synced 2026-01-18 21:21:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

make decodeFont and decodeAudio non virtual

Browse Source 
This was causing the Lambda recorder builds to fail as these methods weren't linking properly because they were never overridden (super strange seems like a compiler or linker bug). We don't need these to be virtual as the logic for returning the correct concrete object is always known at compile time.

```
Linking rive_thumbnail_generator
/usr/bin/ld:../../renderer/build/linux/bin/release/librive_skia_renderer.a(skia_factory.o):(.data.rel.ro+0x190): undefined reference to `rive::Factory::decodeFont(rive::Span<unsigned char const>)'
/usr/bin/ld:../../renderer/build/linux/bin/release/librive_skia_renderer.a(skia_factory.o):(.data.rel.ro+0x198): undefined reference to `rive::Factory::decodeAudio(rive::Span<unsigned char const>)'
clang: error:linker command failed with exit code 1 (use -v to see invocation)
```

Diffs=
aee913977a make decodeFont and decodeAudio non virtual (#9025)

Co-authored-by: Luigi Rosso <luigi-rosso@users.noreply.github.com>
This commit is contained in:
luigi-rosso
2025-02-12 05:06:07 +00:00
parent 33d561d37e
commit ce1d6a1803
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.rive_head
View File

@@ -1 +1 @@
e816b03089efc637b6161d55e8a1543d07bdbae9
aee913977a8ffb8dd7df5bf5eb2951f02344eb48

4
include/rive/factory.hpp
View File

@@ -60,9 +60,9 @@ public:
virtual rcp<RenderImage> decodeImage(Span<const uint8_t>) = 0;
virtual rcp<Font> decodeFont(Span<const uint8_t>);
rcp<Font> decodeFont(Span<const uint8_t>);
virtual rcp<AudioSource> decodeAudio(Span<const uint8_t>);
rcp<AudioSource> decodeAudio(Span<const uint8_t>);
// Non-virtual helpers