From 458db0d80c5344d728dd28cc1f9c838952a04ac8 Mon Sep 17 00:00:00 2001 From: Syoyo Fujita Date: Fri, 16 Jan 2026 06:43:27 +0900 Subject: [PATCH] Add RectLight to pprint value type dispatch - Add RectLight to CASE_GPRIM_LIST macro in value-pprint.cc - This fixes "VALUE_PPRINT: TODO: (type: RectLight)" output - Remove usdlux_*.usda from KNOWN_FAILURES as they now pass roundtrip Co-Authored-By: Claude Opus 4.5 --- src/value-pprint.cc | 1 + tests/usda/roundtrip-runner.py | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/value-pprint.cc b/src/value-pprint.cc index 3925c073..56c5d0e1 100644 --- a/src/value-pprint.cc +++ b/src/value-pprint.cc @@ -773,6 +773,7 @@ namespace value { __FUNC(DiskLight) \ __FUNC(DistantLight) \ __FUNC(CylinderLight) \ + __FUNC(RectLight) \ __FUNC(SkelRoot) \ __FUNC(Skeleton) \ __FUNC(SkelAnimation) \ diff --git a/tests/usda/roundtrip-runner.py b/tests/usda/roundtrip-runner.py index 59f8a35c..d559c779 100644 --- a/tests/usda/roundtrip-runner.py +++ b/tests/usda/roundtrip-runner.py @@ -11,9 +11,6 @@ import subprocess # Known failing files - these have known issues with roundtrip # that should be fixed in the future KNOWN_FAILURES = [ - # UsdLux types not fully supported in pprinter (outputs "VALUE_PPRINT TODO:") - "usdlux_advanced_features.usda", - "usdlux_basic_lights.usda", # Spectral emission (wavelength:emission) not fully supported "spectral-emission-002.usda", "spectral-emission-preset-f2.usda",