mirror of
https://github.com/openssl/openssl.git
synced 2026-01-18 17:11:31 +01:00
8655a91c79
Somewhere in our conversion from .c files to .inc files for our rand providers, we created code in drbg_hmac_set_ctx_params_locked to fetch our digest and hmac when creating the rand instance. However, the function drbg_fetch_algs_from_prov only fetched our digest for this rand type, not the hmac, and returned 1 while doing so, indicating success. This is problematic because it means that we never wind up fetching an HMAC for this rand type. As a result we never compute the strength of the DRBG and so any attempt to seed it fails. Ensure that, if we load a digest for this DRBG, we also fetch an HMAC, and fail if we can't do so, so the HMAC-DRBG is useful. Fixes openssl/private#853 Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> (Merged from https://github.com/openssl/openssl/pull/29560)