Mirrors/libressl
0
0
Fork 0
mirror of https://github.com/libressl/portable.git synced 2026-01-17 21:51:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

pthreads.h: avoid undefined behavior

Browse Source 
You can't pass a function pointer through a void pointer.
So wrap the pthread callback in a struct.

Fixes #966
This commit is contained in:
Theo Buehler
2023-12-12 23:20:44 +01:00
parent 223bc4e01e
commit 0491aef86c
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
include/compat/pthread.h
View File

@@ -30,18 +30,23 @@ struct pthread_once {
};
typedef struct pthread_once pthread_once_t;
struct _pthread_win32_cb_arg {
void (*cb)(void);
};
static inline BOOL CALLBACK
_pthread_once_win32_cb(PINIT_ONCE once, PVOID param, PVOID *context)
{
void (*cb) (void) = param;
cb();
struct _pthread_win32_cb_arg *arg = param;
arg->cb();
return TRUE;
}
static inline int
pthread_once(pthread_once_t *once, void (*cb) (void))
{
BOOL rc = InitOnceExecuteOnce(&once->once, _pthread_once_win32_cb, cb, NULL);
struct _pthread_win32_cb_arg arg = { .cb = cb };
BOOL rc = InitOnceExecuteOnce(&once->once, _pthread_once_win32_cb, &arg, NULL);
if (rc == 0)
return -1;
else