Mirrors/cxxopts
0
0
Fork 0
mirror of https://github.com/jarro2783/cxxopts.git synced 2026-01-18 01:11:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: Switch to stable_partition to ensure that only first long options is printed in help (#481)

Browse Source 
* feat: Add test for Ordering of multiple long options

* fix: Use stable_partition for deterministic ordering
This commit is contained in:
Nitin Kumar
2026-01-14 01:27:04 +05:30
committed by GitHub
parent 0f1c5a0a79
commit 89985f820e
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/cxxopts.hpp
View File

@@ -2339,7 +2339,7 @@ OptionAdder::operator()
// (length-1) and longer names // (length-1) and longer names
std::string short_name {""}; std::string short_name {""};
auto first_short_name_iter = auto first_short_name_iter =
std::partition(option_names.begin(), option_names.end(), std::stable_partition(option_names.begin(), option_names.end(),
[&](const std::string& name) { return name.length() > 1; } [&](const std::string& name) { return name.length() > 1; }
); );
auto num_length_1_names = (option_names.end() - first_short_name_iter); auto num_length_1_names = (option_names.end() - first_short_name_iter);

31
test/options.cpp
View File

@@ -1191,3 +1191,34 @@ TEST_CASE("No Options help", "[options]")
CHECK_NOTHROW(options.parse(argc, argv)); CHECK_NOTHROW(options.parse(argc, argv));
CHECK(options.help().find("test <posArg1>...<posArgN>") != std::string::npos); CHECK(options.help().find("test <posArg1>...<posArgN>") != std::string::npos);
} }
TEST_CASE("Ordering of multiple long options", "[help]")
{
cxxopts::Options options("test", "Ordering of multiple long options");
options.add_options()
("x,alphax,betax,gammax,deltax", "Multiple names x", cxxopts::value<int>())
("deltay,gammay,y,betay,alphay", "Multiple names y", cxxopts::value<int>())
("alphaz,betaz,z", "Multiple names z", cxxopts::value<int>())
("alphaw,w", "Multiple names w", cxxopts::value<int>())
("beta,gamma,alpha,delta", "Without short name", cxxopts::value<int>());
auto opts = options.group_help("").options;
// Veryfiy ordering
REQUIRE(opts.size()==5);
CHECK(opts[0].l == std::vector<std::string>{"alphax", "betax", "gammax", "deltax"});
CHECK(opts[1].l == std::vector<std::string>{"deltay", "gammay", "betay", "alphay"});
CHECK(opts[2].l == std::vector<std::string>{"alphaz", "betaz"});
CHECK(opts[3].l == std::vector<std::string>{"alphaw"});
CHECK(opts[4].l == std::vector<std::string>{"beta", "gamma", "alpha", "delta"});
std::string help = options.help();
// Verify first long options are always present in help output
CHECK(help.find("--alphax") != std::string::npos);
CHECK(help.find("--deltay") != std::string::npos);
CHECK(help.find("--alphaz") != std::string::npos);
CHECK(help.find("--alphaw") != std::string::npos);
CHECK(help.find("--beta") != std::string::npos);
}