mirror of
https://github.com/curl/curl.git
synced 2026-01-18 17:21:26 +01:00
2ec54556d4
- add 'use warnings' and 'use strict' where missing from Perl scripts. - fix 'Use of uninitialized value'. - fix missing declarations. - test1140.pl: fix 'Possible precedence issue with control flow operator'. - fix other misc issues. Most actual errors found during this PR were fixed and merged via separate PRs. Likely there are remaining warnings not found and fixed in this PR. Closes #17877
88 lines
1.9 KiB
Perl
Executable File
88 lines
1.9 KiB
Perl
Executable File
#!/usr/bin/env perl
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
# bad[:=]correct
|
|
#
|
|
# If separator is '=', the string will be compared case sensitively.
|
|
# If separator is ':', the check is done case insensitively.
|
|
#
|
|
# To add white listed uses of bad words that are removed before checking for
|
|
# the bad ones:
|
|
#
|
|
# ---(accepted word)
|
|
#
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
my @whitelist;
|
|
my %alt;
|
|
my %exactcase;
|
|
|
|
my @w;
|
|
while(<STDIN>) {
|
|
chomp;
|
|
if($_ =~ /^#/) {
|
|
next;
|
|
}
|
|
if($_ =~ /^---(.*)/) {
|
|
push @whitelist, $1;
|
|
}
|
|
elsif($_ =~ /^([^:=]*)([:=])(.*)/) {
|
|
my ($bad, $sep, $better)=($1, $2, $3);
|
|
push @w, $bad;
|
|
$alt{$bad} = $better;
|
|
if($sep eq "=") {
|
|
$exactcase{$bad} = 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
my $errors;
|
|
|
|
sub file {
|
|
my ($f) = @_;
|
|
my $l = 0;
|
|
open(F, "<$f");
|
|
while(<F>) {
|
|
my $in = $_;
|
|
$l++;
|
|
chomp $in;
|
|
if($in =~ /^ /) {
|
|
next;
|
|
}
|
|
# remove the link part
|
|
$in =~ s/(\[.*\])\(.*\)/$1/g;
|
|
# remove backticked texts
|
|
$in =~ s/\`.*\`//g;
|
|
# remove whitelisted patterns
|
|
for my $p (@whitelist) {
|
|
$in =~ s/$p//g;
|
|
}
|
|
foreach my $w (@w) {
|
|
my $case = $exactcase{$w};
|
|
if(($in =~ /^(.*)$w/i && !$case) ||
|
|
($in =~ /^(.*)$w/ && $case) ) {
|
|
my $p = $1;
|
|
my $c = length($p)+1;
|
|
print STDERR "$f:$l:$c: error: found bad word \"$w\"\n";
|
|
printf STDERR " %4d | $in\n", $l;
|
|
printf STDERR " | %*s^%s\n", length($p), " ",
|
|
"~" x (length($w)-1);
|
|
printf STDERR " maybe use \"%s\" instead?\n", $alt{$w};
|
|
$errors++;
|
|
}
|
|
}
|
|
}
|
|
close(F);
|
|
}
|
|
|
|
my @files = @ARGV;
|
|
|
|
foreach my $each (@files) {
|
|
file($each);
|
|
}
|
|
exit $errors;
|